Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check output type before storing cache entry #451

Closed
acatl opened this issue Apr 15, 2020 · 0 comments · Fixed by #452
Closed

check output type before storing cache entry #451

acatl opened this issue Apr 15, 2020 · 0 comments · Fixed by #452
Assignees
@acatl
Labels
📦data-point-service DataPointService Package

Comments

@acatl
Copy link
Collaborator

acatl commented Apr 15, 2020

Problem description:

On data-point-service we currently do not run the entity's outputType reducer before storing the new key, this means that if the outpuType was to fail, a key would be stored anyways causing the entry to be corrupted and served/stored for as long as the cache is configured.

Suggested solution:

Run outputType reducer right before attempting to store the entry key, if it fails the entry will not be executed and it will be handled as an error.

Environment:

  • data-point version: all
  • node version: all
  • npm version: all
@acatl acatl added the 📦data-point-service DataPointService Package label Apr 15, 2020
@acatl acatl self-assigned this Apr 15, 2020
acatl added a commit to acatl/data-point that referenced this issue Apr 15, 2020
@acatl
feat(data-point-service): run outputType before adding entry
b87e20b 
output type if set, it must pass in order for the entry to be added to cache store

fix ViacomInc#451
@acatl acatl mentioned this issue Apr 15, 2020
Merged
5 tasks
acatl added a commit that referenced this issue Apr 20, 2020
@acatl
feat(data-point-service): run outputType before adding entry (#452)
97f54f0 
output type if set, it must pass in order for the entry to be added to the cache store

fix #451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acatl acatl

Labels
📦data-point-service DataPointService Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(data-point-service): run outputType before adding entry acatl/data-point
1 participant
@acatl