Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resetCache should clear stale data #492

Open
schiavig opened this issue Feb 9, 2024 · 0 comments
Open

resetCache should clear stale data #492

schiavig opened this issue Feb 9, 2024 · 0 comments
Labels
📦data-point-service DataPointService Package

Comments

@schiavig
Copy link
Collaborator

schiavig commented Feb 9, 2024

Problem description:
When resetCache is true the promise chain ignore saved values but stale data is not removed

Suggested solution:
Clear stale data during the promise chain

What happened:

Reproduction:

Environment:

  • data-point version:
  • node version:
  • npm version:
@schiavig schiavig added the 📦data-point-service DataPointService Package label Feb 9, 2024
schiavig added a commit to schiavig/data-point that referenced this issue Feb 9, 2024
@schiavig
fix(data-point-service): resetCache should clear stale data
6fc0c7b 
resetCache should clear stale data

fix ViacomInc#492
This was referenced Feb 9, 2024
Closed
Merged
schiavig added a commit to schiavig/data-point that referenced this issue Feb 9, 2024
@schiavig
fix(data-point-service): resetCache should clear stale data
94eb2b6 
resetCache doesn't remove stale data so, it happens that for removed contents it still provide old
data. Implemented the clear of stale data on promise chain

fix ViacomInc#492
schiavig added a commit to schiavig/data-point that referenced this issue Feb 9, 2024
@schiavig
fix(data-point-service): resetCache should clear stale data
d3db273 
resetCache doesn't remove stale data so, it happens that for removed contents it still provide old
data. Implemented the clear of stale data on promise chain

fix ViacomInc#492
schiavig added a commit that referenced this issue Feb 12, 2024
@schiavig
fix(data-point-service): resetCache should clear stale data (#494)
8f2e60f 
* fix(data-point-service): resetCache should clear stale data

resetCache doesn't remove stale data so, it happens that for removed contents it still provide old
data. Implemented the clear of stale data on promise chain when the clear cache parameter is applied

fix #492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📦data-point-service DataPointService Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(data-point-service): resetCache should clear stale data schiavig/data-point
1 participant
@schiavig