Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotary encoders cannot use macros #19

Closed
monkeychou opened this issue Mar 20, 2021 · 10 comments
Closed

Rotary encoders cannot use macros #19

monkeychou opened this issue Mar 20, 2021 · 10 comments

Comments

@monkeychou
Copy link

The encoder uses a macro, but there is no response
I'm not good at English

@xyzz
Copy link
Contributor

xyzz commented Mar 20, 2021

Please upload your QMK source files including all configuration & Vial JSON.

@monkeychou
Copy link
Author

this is my source files

newpad.zip

@monkeychou
Copy link
Author

vial.json.zip

@xyzz
Copy link
Contributor

xyzz commented Mar 20, 2021

It looks like the same issue we've seen before, it is running out of stack memory and clashing with the global data, corrupting random data (you can confirm it by disabling RGBLIGHT_ENABLE and then macros execute ok). Though I am not sure why it would run out in this particular case as it looks like there should be plenty of memory available.

@xyzz
Copy link
Contributor

xyzz commented Mar 21, 2021

After looking into it more, it is actually caused by a memory corruption when layer cache is being updated. So I've fixed it in vial-qmk encoder-simplify branch, please try it and let me know if it resolves the issue: https://github.com/vial-kb/vial-qmk/tree/encoder-simplify

@monkeychou
Copy link
Author

Yes, the encoder can use macros, but will touch off twice。

20210322.mp4

@xyzz
Copy link
Contributor

xyzz commented Mar 22, 2021

ah my bad, try updating the branch I just fixed that

@monkeychou
Copy link
Author

ah my bad, try updating the branch I just fixed that

Perfect. Thank you very much

@xyzz
Copy link
Contributor

xyzz commented Mar 22, 2021

fixed in vial-kb/vial-qmk@c69a05c

@xyzz xyzz closed this as completed Mar 22, 2021
@anubhavd7
Copy link

@xyzz hello sir i want to make a macropad with just one rotary encoder. i am facing a problem in it the button key is working perfectly but the rotary part clockwise and anticlockwise is not working. I have tried alot of things but nothing is working out can you please help me in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants