Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4MDPatternBasedMatchSetProvider disposes shared engine #22

Open
ujhelyiz opened this issue Feb 4, 2019 · 1 comment
Open

V4MDPatternBasedMatchSetProvider disposes shared engine #22

ujhelyiz opened this issue Feb 4, 2019 · 1 comment
Assignees
@ujhelyiz

Comments

@ujhelyiz
Copy link
Member

ujhelyiz commented Feb 4, 2019

When calling V4MDPatternBasedMatchSetProvider#dispose (that is called by the VIATRA test framework) disposes the shared VIATRA Query engine of the project. In more complex scenarios (e.g. when trying to reuse the model to spare the load/close project times) this can be unhelpful...

We should either provide a way for test cases to use a separate (non-shared) matcher, or we should not dispose the query engine here.
@istvanrath
Copy link

Related to #31

@ujhelyiz ujhelyiz self-assigned this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ujhelyiz ujhelyiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ujhelyiz @istvanrath