Use io_uring for files on linux #175
Conversation
There was a problem hiding this comment.
I'm really glad to see this since I really wanted to try this out myself when it got into the kernel, but couldn't realistically do so due to higher priorities.
Since I can't test this locally in the current state, my only comment right now is that the integration should be optional as a separate build configuration. Once that is done, everything builds, and the white space changes and Meson build file changes are in separate commits, we could also just document it as experimental and merge it to master, so that improvements can be made in smaller incremental steps.
dub.sdl
Outdated
| @@ -2,7 +2,8 @@ name "eventcore" | |||
| description "Pro-actor based abstraction layer over operating system asynchronous I/O facilities." | |||
| license "MIT" | |||
| copyright "Copyright © 2016-2018 Sönke Ludwig" | |||
|
|
|||
| license "MIT" | |||
| @@ -2,7 +2,8 @@ name "eventcore" | |||
| description "Pro-actor based abstraction layer over operating system asynchronous I/O facilities." | |||
| license "MIT" | |||
| copyright "Copyright © 2016-2018 Sönke Ludwig" | |||
|
|
|||
| license "MIT" | |||
| dependency "during" version="~>0.2.1" | |||
There was a problem hiding this comment.
This should be in a new "uring" configuration at the bottom of the file. Is "during" a local package of yours? I don't see it on code.dlang.org.
There was a problem hiding this comment.
Since I can't test this locally in the current state, my only comment right now is that the integration should be optional as a separate build configuration. Once that is done, everything builds, and the white space changes and Meson build file changes are in separate commits, we could also just document it as experimental and merge it to master, so that improvements can be made in smaller incremental steps.
Great! Than I will polish it up to be suitable for master.
There was a problem hiding this comment.
This should be in a new "uring" configuration at the bottom of the file. Is "during" a local package of yours? I don't see it on code.dlang.org.
It's https://github.com/tchaloupka/during from code.dlang.org
There was a problem hiding this comment.
white space changes
which one?
There was a problem hiding this comment.
Hm it's really just two lines in utils.d, nevermind then, I thought it was more.
There was a problem hiding this comment.
It's https://github.com/tchaloupka/during from code.dlang.org
Interesting, the search is obviously broken w.r.t. package names. Accessing it manually works, but I get zero results for "during".
Panke
force-pushed
the
master
branch
2 times, most recently
from
956bebf
to
1b7e274
Compare
Also changes the way the internal data is organized to match the module comment of io_uring.
This is a proof of concept on how to integrate io_uring into the epoll event loop. It currently supports files, timers could be easily added (but prolly require a fork of the PosixEventLoop).
It's not production ready yet, but I want to gather some early feedback.