Dont use OpenSSL SSLv3* methods #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They have been disabled on Debian, causing vibe.d to fail to compile. SSLv3 only connections can still be achieved by passing the appropriate SSL_OP_NO_* options to OpenSSL
|
I thought vibe.d was using botan by default? Could be wrong though |
|
It's still using OpenSSL by default. Botan is still critical w.r.t. linking on Windows due to its size (although it received some improvements recently). You need to explicitly |
|
Changes look good. I'll merge and tag another RC. |
s-ludwig
added a commit
that referenced
this pull request
Nov 3, 2015
Dont use OpenSSL SSLv3* methods. Fixes #1315.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have been disabled on Debian, causing vibe.d to fail to compile.
SSLv3 only connections can still be achieved by passing the appropriate
SSL_OP_NO_* options to OpenSSL
See #1315