New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use OpenSSL SSLv3* methods #1316

Merged
merged 1 commit into from Nov 3, 2015

Conversation

Projects
None yet
3 participants
@lultimouomo
Contributor

lultimouomo commented Nov 2, 2015

They have been disabled on Debian, causing vibe.d to fail to compile.
SSLv3 only connections can still be achieved by passing the appropriate
SSL_OP_NO_* options to OpenSSL

See #1315

Dont use OpenSSL SSLv3* methods
They have been disabled on Debian, causing vibe.d to fail to compile.
SSLv3 only connections can still be achieved by passing the appropriate
SSL_OP_NO_* options to OpenSSL
@dariusc93

This comment has been minimized.

Show comment
Hide comment
@dariusc93

dariusc93 Nov 3, 2015

Contributor

I thought vibe.d was using botan by default? Could be wrong though

Contributor

dariusc93 commented Nov 3, 2015

I thought vibe.d was using botan by default? Could be wrong though

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Nov 3, 2015

Member

It's still using OpenSSL by default. Botan is still critical w.r.t. linking on Windows due to its size (although it received some improvements recently). You need to explicitly dub fetch botan to make it get used, but then it will currently still link against OpenSSL. dlang/dub#361 is needed to be able to freely opt out/in of a certain implementation.

Member

s-ludwig commented Nov 3, 2015

It's still using OpenSSL by default. Botan is still critical w.r.t. linking on Windows due to its size (although it received some improvements recently). You need to explicitly dub fetch botan to make it get used, but then it will currently still link against OpenSSL. dlang/dub#361 is needed to be able to freely opt out/in of a certain implementation.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Nov 3, 2015

Member

Changes look good. I'll merge and tag another RC.

Member

s-ludwig commented Nov 3, 2015

Changes look good. I'll merge and tag another RC.

s-ludwig added a commit that referenced this pull request Nov 3, 2015

Merge pull request #1316 from lultimouomo/fix_debian_openssl
Dont use OpenSSL SSLv3* methods. Fixes #1315.

@s-ludwig s-ludwig merged commit 46859be into vibe-d:master Nov 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment