Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual trigger: Button on PR page #103

Closed
avikalpg opened this issue May 29, 2024 · 2 comments · Fixed by #110
Closed

Manual trigger: Button on PR page #103

avikalpg opened this issue May 29, 2024 · 2 comments · Fixed by #110
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@avikalpg
Copy link
Member

Currently, the UX for manually triggering Vibinex on a pull request is sub-optimal. The user has to copy the link of the pull request (which also has to be the root link of the pull request), paste it into the popup window (right next to the "Logout" button) and then click "Trigger".

A much better UX would be to have a button on the pull request page that can just be clicked to trigger Vibinex.

Optional: Show different states of the button:

  • Default: The button is ready to be clicked with the Vibinex refresh symbol, and the tooltip text "Process this PR on Vibinex".
  • Highlighted: If the pull request is not processed even once before, change the styling of the button to highlight it more.
  • On Click: As soon as the user clicks the button, it should become disabled and the text should change to "Triggering..."
  • Processing: Once the trigger is successful, the button should still be disabled, but the color should change to a shade of green and the text should change to "Processing...".
  • Done: Once the hunks table row for the pull request has a last_modified_at timestamp greater than the time of the click, we can change the text of the button to "Done!". Then we can either refresh the page or just trigger the UI update function again. The button should change back to the "Default" state once the UI is updated.
@harith-aaron
Copy link

Hi @avikalpg , I am ready to work on it can you assign me now?

@avikalpg
Copy link
Member Author

Hi @harith-aaron, thanks for your interest.
Before I assign the issue to you, can you describe your approach to resolving this issue?

I can assign the issue to you once we agree on your approach (and hopefully the LLD).

@avikalpg avikalpg self-assigned this Aug 16, 2024
@avikalpg avikalpg linked a pull request Aug 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants