Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming/docs based on feedback from internal beta #71

Closed
StannisZhou opened this issue Sep 17, 2021 · 0 comments · Fixed by #88
Closed

Update naming/docs based on feedback from internal beta #71

StannisZhou opened this issue Sep 17, 2021 · 0 comments · Fixed by #88
Milestone
0.2.1

Comments

@StannisZhou
Copy link
Contributor

StannisZhou commented Sep 17, 2021 •
edited
Loading

From @lawchekun :

  • key_tuple in GenericVariableGroup -> variable_names
  • In general maybe move away from using keys and instead use names
  • Would probably be helpful if there's a short example showing that init_msgs can be used to setup/trigger the belief_propagation too in run_bp
@StannisZhou StannisZhou changed the title Update naming based on feedback from internal beta Update naming/docs based on feedback from internal beta Sep 22, 2021
@StannisZhou StannisZhou added this to the 0.2.1 milestone Oct 11, 2021
This was referenced Oct 20, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.1
Development

Successfully merging a pull request may close this issue.

Moving to a functional interface StannisZhou/PGMax-private
1 participant
@StannisZhou