Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMAPI scripts testing for VSMREQIN don't actually test connectivity #92

Closed
viccross opened this issue Mar 29, 2022 · 2 comments · Fixed by #95
Closed

SMAPI scripts testing for VSMREQIN don't actually test connectivity #92

viccross opened this issue Mar 29, 2022 · 2 comments · Fixed by #95
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@viccross
Copy link
Owner

If communication with the TCPIP SVM has been interrupted in any way, the VSMREQIN SVM will be up but its listener will not be ready. So the script testing for the presence of VSMREQIN is useless since it may not be contactable.

Related to #91 (if we used IUCV to talk to SMAPI it wouldn't matter about the IP listener).

@viccross viccross added bug Something isn't working enhancement New feature or request labels Mar 29, 2022
@viccross viccross self-assigned this Mar 29, 2022
@viccross
Copy link
Owner Author

viccross commented Apr 1, 2022

smcli qafl should be enough to verify that SMAPI is listening.

However if we switch to IUCV we'll need to test for VSMREQIU, and possibly even still just do the smcli qafl anyway.

@viccross
Copy link
Owner Author

viccross commented Apr 1, 2022

smcli qafl doesn't work out of the box with the ancient smcli being used -- it needs to be patched to support recent SMAPI (update the return/reason code for z/VM 7.2).

viccross added a commit that referenced this issue Apr 1, 2022
Add a test for functional SMAPI in places where the old "is it logged on" is present.  Also added a test to prevent breakage if we run out of disk space in icic-setup.sh.
@viccross viccross linked a pull request Apr 1, 2022 that will close this issue
@viccross viccross mentioned this issue Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant