Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is request cancellation supported #42

Closed
ryanmk54 opened this issue Dec 31, 2020 · 3 comments
Closed

Is request cancellation supported #42

ryanmk54 opened this issue Dec 31, 2020 · 3 comments

Comments

@ryanmk54
Copy link
Contributor

Is request cancellation supported like it is in Axios?
https://github.com/axios/axios#cancellation
@victor-am
Copy link
Owner

victor-am commented Jan 2, 2021 •
edited

Hmmm, if axios 0.19.0 supports it I believe yes since we just forward the params you pass to the request into axios itself.

If not then we could bump the axios version in the project (it's fairly simple, if you are interested in doing it and opening a PR feel free to 😄 otherwise I can do it in a few days).

@ryanmk54
Copy link
Contributor Author

ryanmk54 commented Jan 4, 2021

I have some other bugs that I need to fix first, but if I get time I would like to add a cancellation section to the documentation. Not sure when I'll get to it though.

@victor-am
Copy link
Owner

Solved by #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanmk54 @victor-am