Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backward compatibility of 1.1 with 1.0 #79

Closed
alex-signature-it opened this issue Aug 13, 2015 · 3 comments
Closed

Backward compatibility of 1.1 with 1.0 #79

alex-signature-it opened this issue Aug 13, 2015 · 3 comments
Labels
enhancement

Comments

@alex-signature-it
Copy link

The changes introduced in 1.1, related to providing a factory ngProgressFactory instead of a service (I presume) ngProgress provided in previous versions are not backward compatible and breaks every single usage of ngProgress.
I understand that this change was necessary in order to be able to provide multiple instances of ngProgress and maybe there were other reasons for it I'm not aware of, but would you consider providing ngProgress service along with ngProgressFactory for backward compatibility?
@cetra3
Copy link
Collaborator

cetra3 commented Feb 9, 2016

Hi @alex-signature-it is this still required?

@alex-signature-it
Copy link
Author

Well, I guess anyone interested in the project have updated their code by now. I know I did.

@cetra3
Copy link
Collaborator

cetra3 commented Feb 15, 2016

Ok, I'll close this off. Thanks!

@cetra3 cetra3 closed this as completed Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex-signature-it @cetra3