Use childprocess and sys-proctables gems for more robust starting/stopping #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcastellm
pushed a commit
that referenced
this pull request
Jan 14, 2014
Use childprocess and sys-proctables gems for more robust starting/stopping
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to let the
childprocessandsys-proctablesgems do the heavy lifting when it comes to starting process and figuring out which process to kill on stop. I'm running go1.2, but I'm assuming that go1.0/go1.1 still have the relevant process (whether it bea.outor the new naming convention) as a child of thego runcommand.