Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import ply instead of including it in the distribution #14

Closed
johnyf opened this issue Nov 24, 2013 · 2 comments
Closed

import ply instead of including it in the distribution #14

johnyf opened this issue Nov 24, 2013 · 2 comments

Comments

@johnyf
Copy link
Contributor

johnyf commented Nov 24, 2013

Since ply is developed separately, importing it from site-packages will benefit from any updates and upgrades it experiences.

@victorlei
Copy link
Owner

Please be more specific -- such and such improvements in ply are currently missing in smop and would help smop in such and such ways.

@johnyf
Copy link
Contributor Author

johnyf commented Nov 24, 2013

There are not specific features which I have in mind, the reason was more because it is a package maintained separately and can be installed automatically as a dependency from pypi or whichever other method each user prefers. One observation is that the included yacc is at version 3.3, whereas the current ply is at version 3.5. The minimal benefit will be to automatically follow updates, when users update their installed packages. Otherwise any changes would have to be committed also here.

Since setup does require other packages (numpy, scipy) the smop package is not entirely independent. So numpy and scipy will be fetched in case they are not already installed, hence fetching ply will not be the only cause of installing dependencies during setup.

Another idea might be to use a git submodule (haven't tried it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants