Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVCC: Add configurable charge voltage limit for managed batteries #761

Closed
4 tasks done
izak opened this issue Dec 14, 2020 · 3 comments
Closed
4 tasks done

DVCC: Add configurable charge voltage limit for managed batteries #761

izak opened this issue Dec 14, 2020 · 3 comments
Assignees
Milestone

Comments

@izak
Copy link
Collaborator

izak commented Dec 14, 2020

In some cases, the installer may want to override the charge voltage sent by a managed battery.

The case to solve with this is a temporary condition where there is an imbalance in a brand new battery that simply needs time to balance. A lower charge voltage limit can then be set, allowing room for the high cell and time to balance.

Proposed implementation:

  • This will work similar to the present quirk architecture already in place for some batteries.
  • As before, where such a voltage is set the lower of this voltage and the one sent by the battery will be used.

TODO

  • Add to systemcalc
  • Add setting in GUI
  • Log to VRM
  • Add to modbus-tcp
@izak izak self-assigned this Dec 14, 2020
izak added a commit to victronenergy/dbus-systemcalc-py that referenced this issue Dec 16, 2020
izak added a commit to victronenergy/dbus-systemcalc-py that referenced this issue Dec 17, 2020
Also use zero as the unset value rather than -1.

victronenergy/venus#761
izak added a commit to victronenergy/dbus_modbustcp that referenced this issue Dec 17, 2020
jhofstee pushed a commit to victronenergy/meta-victronenergy that referenced this issue Jan 9, 2021
Add maximum charge voltage setting for managed batteries
    victronenergy/venus#761
jhofstee pushed a commit to victronenergy/meta-victronenergy that referenced this issue Jan 9, 2021
Add registers for EV chargers.
    Closes victronenergy/venus#742
Add register for dvcc max charge voltage setting.
    victronenergy/venus#761
@mpvader
Copy link
Contributor

mpvader commented Jan 21, 2021

@izak how would enabling this new feature affect:

a) an ESS system with lead batteries, a Multi and solarchargers?
b) a non-ESS system of the same config?
c) a system with DVCC off? (I would assume no effect)

@mpvader mpvader added this to the v2.70 milestone Jan 21, 2021
@mpvader
Copy link
Contributor

mpvader commented Jan 21, 2021

And @izak the title of this issue talks about a configurable override charge voltage setting. Is that what it is? Or is it a user configurable upper limit for the charge voltage? Which would leave the system operating as is, accepting also any lower charge voltage setpoints, but limiting them to the configured value.

@izak
Copy link
Collaborator Author

izak commented Jan 21, 2021

a) an ESS system with lead batteries, a Multi and solarchargers?

Only affects systems with a BMS, so no change in systems with a lead acid battery. The charge voltage configured on the Multi is used.

b) a non-ESS system of the same config?

In a system with a managed battery, the solar chargers will use the lesser of this setting, or what the battery asked for.

In a system without a managed battery, this setting has no effect.

c) a system with DVCC off? (I would assume no effect)

Completely ignored, only used with DVCC.

The labels in the GUI is "Limit managed battery charge voltage", and it is only shown if DVCC is on. So I believe this should be clear to the user.

title of this issue talks about a configurable override charge voltage setting. Is that what it is? Or is it a user configurable upper limit for the charge voltage?

It is the second one, so technically the title of the issue isn't accurate. It is a user configurable limit, but it will not allow the user to exceed the voltage sent by the managed battery.

@izak izak changed the title DVCC: Add configurable override charge voltage setting DVCC: Add configurable charge voltage limit for managed batteries Jan 21, 2021
mpvader pushed a commit to victronenergy/meta-victronenergy that referenced this issue Feb 28, 2021
Add maximum charge voltage setting for managed batteries
    victronenergy/venus#761

(cherry picked from commit 27f9fc2)
mpvader pushed a commit to victronenergy/meta-victronenergy that referenced this issue Feb 28, 2021
Add maximum charge voltage setting for managed batteries
    victronenergy/venus#761

(cherry picked from commit 27f9fc2)
mpvader pushed a commit to victronenergy/meta-victronenergy that referenced this issue Feb 28, 2021
Add registers for EV chargers.
    Closes victronenergy/venus#742
Add register for dvcc max charge voltage setting.
    victronenergy/venus#761

(cherry picked from commit 550b762)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants