Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Istanbul reporting different data. #2125

Closed
itsjamie opened this issue Feb 12, 2019 · 2 comments
Closed

Fix Istanbul reporting different data. #2125

itsjamie opened this issue Feb 12, 2019 · 2 comments

Comments

@itsjamie
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Istanbul is reporting odd behaviour where the number of run tests can change between executions and thus the coverage can change quite a bit run to run.

Describe the solution you'd like
I wonder if it is because of the out of date Webpack loader we're using to work with Istanbul. It seems like some of the community has forked from https://github.com/webpack-contrib/istanbul-instrumenter-loader to https://github.com/JS-DevTools/coverage-istanbul-loader instead because of lingering PRs. I wonder if updating to use this new package would help.

Describe alternatives you've considered
I wondered if we were bringing all the testing sources in properly, haven't confirmed either way.

Additional context
#2123 (comment)

@itsjamie itsjamie self-assigned this Feb 14, 2019
@itsjamie
Copy link
Collaborator Author

@johnBartos you weren't crazy.

screen shot 2019-02-13 at 11 37 48 pm

Looking into updating and seeing if it can still be reproduced.

@itsjamie
Copy link
Collaborator Author

Tried upgrading Karma, changing Istanbul coverage reporter, and switching back to bundling a webpack build for every test rather than a single entry test.

All of these methods still had shaky reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant