Sync audio fragment loading with main discontinuity and time #6491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
feature/sync-alt-audio-disco
branch
from
275ac39
to
eed4244
Compare
robwalch
force-pushed
the
feature/sync-alt-audio-disco
branch
from
eed4244
to
20f50af
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Ensure that audio-stream-controller loads segments from the same discontinuity domain (
cc) as the main stream-controller.Sync max audio buffer target with main playlist loading fragment (rather than video SourceBuffer end).
Properties defined in the base stream controller class are now set and reset there where possible.
Why is this Pull Request needed?
This PR improves Live start and VOD resume at offset by selecting audio segments that align with selected video segments. Required to stable primary playback resumption in #5730.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist