Fix audio segment loading when main segments loaded out of sequence #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
robwalch
force-pushed
the
bugfix/audio-loading-regression-in-dev
branch
from
3a396ab
to
5650e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fixes a shortcoming in #6491 that assumes the last fragment of the main playlist to be loaded is nearest to the end of the buffer.
Why is this Pull Request needed?
Prevents audio from not loading up to a previously appended video buffer range after appended audio was ejected.
This was a regression in dev discovered while testing #6529.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist