-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simpleton live alt-audio support inspired by the stream-controller. #727
Conversation
The code seems to work with a single video level stream. On a multi-level video stream, the audio seems to stop working as soon as the level is changed, and seems to resume if it goes back to the original video level. I believe this might be another issue by itself. Feel free to reject this pull request and just get inspired if you think it's better off being re-written another way. |
Hi @fredvb it is a good start. |
There is another important constraint for live alt audio: timestamp needs to be synced between main/alt audio. It is not the case currently... it was not an issue for VoD as main and audio share the same timeline. But this is needed as the two playlists are not sliding in sync. this might require providing a reference PTS to audio demuxer, this reference PTS being extracted from main demuxer. This ref PTS could be provided in FRAG_PARSING_DATA. |
Oh my, my personal repo's merge is attempting to commit to this.. I'm lost, should I not be merging my repos until I have a more final change ? Or is this OK ? I'm not sure if you'd want a merge to appear further down the road if you approve upcoming changes. Lemme know what is your preference. We can always redo a fresh pull request that doesn't require a merge later on. |
you should better rebase your PR instead of merging upstream. |
@mangui "regarding live alt-audio and level switch not working with your changes, could you share a playlist ?" I couldn't reproduce it at the moment, but if I encounter it again, I'll try to send you what I can. |
Confirmed lip sync problems with alt audio |
@mangui I must say, I've look around in the demuxer, stream controllers and remuxers and I'm not too sure how you'd want to do this. Any more clues might help. |
Going to re-investigate my options after looking at your commit dailymotion@dcf67a1 |
@mangui I think I'm going to have to withdraw my attempt at fixing the sync issue. |
the idea would be to propagate initPTS/initDTS info in FRAG_PARSING_INIT_SEGMENT event this will then ease to keep main and audio demuxer in sync. I can look into it providing that I have live alt-audio test streams available. |
@mangui sent u by mail a live m3u8 for alternative audio |
here's another live m3u8 with alternate audio: |
The initPTS relaying is already handled using a |
And there is this playlist http://haiv-nginx-test.westeurope.cloudapp.azure.com/master.m3u8 which is the same as @nitrat7 's stream but with the CODECS included. (makes the video work) |
Got an Elemental Live demuxed low latency test steam for you, folks : |
Merge branch 'pull-727' into new-live-alternative-audio
closing in favor of #860 that also contains these changes |
For issue #718
This is a very barebone attempt at making Live streams work with alt-audio.
Any advice or suggestions or full rewrites are welcome.
I'm not sure why the travis-ci failed though.