Feature webvtt #700
Feature webvtt #700
Conversation
Added WebVTT option to config (on by default - switched CEA708 off by default). Added tracks to player for subtitle languages on manifest loaded. Extended playlist loader to handle subtitle tracks.
Modified playlist loader to identify subtitle playlists as such. Initial work on subtitle stream controller. Activated parsing and downloading of subtitle fragment by triggering event. Initial work on WebVTT file content parser.
Added events, generic WebVTT error. Added event and logic to extract initial PTS via event for subtitle synchronisation.
Added 33-bit wraparound fix. Fixed encoding of special characters.
Added event fired when subtitle fragment has been processed and a new can be fetched. Store unparsed fragments if no initial PTS has been received. Add cues to media when parsed. Fire event upon parsing success or failure. Reload live playlist at interval (10 seconds). Created queue for subtitle fragments awaiting fetching and parsing. Keep track of successfully processed fragments.
Set subtitles labeled default to "showing". Add subtitle track ID to fragment and got rid of silly guesswork. Cleaned a bit of code.
…rs, skipping to next.
Also triggered event in case no data is received, for whatever reason. Fixed typo.
…iable:
"{fooBar : fooBar}" is the same as "{fooBar}"
| @@ -90,6 +114,25 @@ class TimelineController extends EventHandler { | |||
| this.lastPts = Number.NEGATIVE_INFINITY; | |||
| } | |||
|
|
|||
| onManifestLoaded(data) { | |||
| // TODO: actually remove the tracks from the media object. | |||
There was a problem hiding this comment.
It's not possible to remove tracks from a video tag - only cues from the tracks object
There was a problem hiding this comment.
Hah, yeah I found out some time after writing that comment. Then forgot to remove it. Sorry about that. 😀
| } | ||
|
|
||
| /** get index of the selected subtitle track (index in subtitle track lists) **/ | ||
| get subtitleTrack() { |
There was a problem hiding this comment.
I think this is better worded as currentTrack, following the trend of levels and currentLevel
|
@coolheinze I'd really like this in before Chrome 55 so I'll review and test this PR on my end - @mangui Have you had a chance to look at this yet? Happy to help here. |
| @@ -0,0 +1,145 @@ | |||
| /* | |||
| * audio track controller | |||
| } | ||
|
|
||
| onMediaDetaching() { | ||
| // TODO: Remove event listeners. |
There was a problem hiding this comment.
this.unregisterListeners() should do it
|
@johnBartos Keep in mind, though, that vtt.js (https://github.com/mozilla/vtt.js) has a bug (tiny, easy to fix but critical nonetheless). I made a pull request a long time ago, which they haven't looked at, so they won't fix it in a hurry, by the looks of it. But I'm sure you'll manage quite well. 😄 |
|
@johnBartos seems vtt.js have approved my PR: mozilla/vtt.js#353 |
|
@coolheinze I had a PR up which had this PR in a working state but there were some issues with it (so I took it down). Just some stuff from our fork that shouldn't be in the PR. However, there's one real issue: removing text tracks. Since we cannot remove them duplicates or extraneous tracks become a serious problem when switching streams or coming back from an ad break. Say you switch from stream 1 to stream 2, where stream 1 had tracks and stream 2 has new tracks I tried reusing the tracks but ran into several problems there; however, coming up with a reuse system is definitely the way to go. In our player, we remove and replace the video tag whenever we switch streams to avoid this problem. |
|
Yeah, I am well aware of that problem. Quite odd that you cannot remove the tracks, but it might be because they can be added through several mechanisms and not just programmatically. Anyway, that's another story. We would - in our use case - tear down and replace the video tag like you wrote. That is, however, up to the script implementing hls.js to handle that, so we left it where it is. I haven't encountered your mid roll ad issue, as it is pretty far from our use case. However, my take on it would be to create another video tag on top and keep the ad and main clip separated hermetically. |
|
superseded by https://github.com/dailymotion/hls.js/pull/922 |
|
My pleasure! 😄 If there's anything else you need help with, don't expect me to be useful at all! 😆 |
|
|
|
Disney must be turning in his grave... 😆 |
Added WebVTT subtitles feature.
I use vtt.js by Mozilla for the actual parsing of the vtt files, although I had to add code to handle the x-timestamp-map header. This does, however, require having an updated version of vtt.js, as there is a small bug in the master. I forked it and created a pull request, and you can find a fixed version of vtt.js here: https://github.com/mediathand/vtt.js/tree/VTTCue-fix
I added a reference to the vtt.js file to the demo index.html file just for testing. Maybe that's not the best solution, but I'll leave dealing with this to the main contributors. :)