Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error type enhancement #1478

Merged
merged 12 commits into from
Jan 25, 2024
Merged

feat: error type enhancement #1478

merged 12 commits into from
Jan 25, 2024

Conversation

wseymour15
Copy link
Contributor

@wseymour15 wseymour15 commented Jan 19, 2024

Description

NOTE: We will need to pull in the newest version of video.js before we can merge this, as there is a dependency on the newly created videojs.Errors: videojs/video.js#8564

The goal of this change is to pass error metadata into MediaErrors in the form of the metadata property so we can gain more details on errors.

Specific Changes proposed

  • Add error types and other metadata when we create errors, so we can more specificity on what type of error is occurring.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

src/media-segment-request.js Outdated Show resolved Hide resolved
src/dash-playlist-loader.js Outdated Show resolved Hide resolved
src/dash-playlist-loader.js Outdated Show resolved Hide resolved
src/segment-loader.js Outdated Show resolved Hide resolved
@wseymour15 wseymour15 marked this pull request as ready for review January 23, 2024 16:31
@wseymour15 wseymour15 self-assigned this Jan 23, 2024
@dzianis-dashkevich
Copy link
Contributor

I think videojs as peer dependency should be updated to a specific version since we are using videojs.Error

@wseymour15
Copy link
Contributor Author

I think videojs as peer dependency should be updated to a specific version since we are using videojs.Error

Will this be problematic? I feel like the peer dependencies are set up that way so we can depend on both versions of video.js, for whatever reason. I did not change package.json for now, but I did update the peer dependency in the lock file

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b87f69) 86.06% compared to head (7dfa955) 86.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
+ Coverage   86.06%   86.10%   +0.03%     
==========================================
  Files          42       42              
  Lines       10748    10749       +1     
  Branches     2474     2474              
==========================================
+ Hits         9250     9255       +5     
+ Misses       1498     1494       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wseymour15 wseymour15 merged commit 8f3a4d1 into main Jan 25, 2024
15 checks passed
@wseymour15 wseymour15 deleted the feat/error-type-enhancement branch January 25, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants