-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error type enhancement #1478
Conversation
I think videojs as peer dependency should be updated to a specific version since we are using |
Will this be problematic? I feel like the peer dependencies are set up that way so we can depend on both versions of video.js, for whatever reason. I did not change package.json for now, but I did update the peer dependency in the lock file |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
+ Coverage 86.06% 86.10% +0.03%
==========================================
Files 42 42
Lines 10748 10749 +1
Branches 2474 2474
==========================================
+ Hits 9250 9255 +5
+ Misses 1498 1494 -4 ☔ View full report in Codecov by Sentry. |
Description
NOTE: We will need to pull in the newest version of video.js before we can merge this, as there is a dependency on the newly created
videojs.Errors
: videojs/video.js#8564The goal of this change is to pass error metadata into MediaErrors in the form of the
metadata
property so we can gain more details on errors.Specific Changes proposed
Requirements Checklist