dispose() does not stop video from downloading on Firefox

[sethborg]

Dispose removes the player but in Firefox (open firebug to the "Net" tab) the movie still loads in the background.

Calling dispose stops the video from downloading any further in chrome but not in Firefox. To do that you need to set the source to blank. Please add this to the dispose function.

// I have to set src to blank before calling dispose in order to make it work in firefox
// dispose() should set src to blank automatically
videojs('video').src('');  //<- Add this to the dispose() function
videojs('video').dispose();

[mmcc]

Want to throw together a pull request for this?

[sethborg]

Not really sure how, also Firefox shows this warning in the console "Invalid URI. Load of media resource failed." so setting src to blank might not be the best way to do it? Any ideas?

[mmcc]

Ok so just looked through the current behavior with @heff, and it looks like the best thing to do here is call disposeMediaElement from the dispose method. Should be a pretty quick and easy fix, so if you're interested in trying your hand at contributing the contributing guide can help you get started. What do you think?

[mmcc]

@sethborg ping. Any interest in putting together a PR for this?

[sethborg]

Not quite sure what to put where. Is this correct?

vjs.Component.prototype.dispose = function(){
  this.trigger('dispose');

  if (this.techName === 'Html5' && this.tag) {
    vjs.Html5.disposeMediaElement(this.tag);
  }
}

Also I noticed calling videojs('bumpboxVideo').src(''); causes the flash player (IE8) to throw an error in vjs.Flash.prototype.play = function(){ this.el_.vjs_play(); };

Edits by @mmcc - Code blocks for readability

[mmcc]

That looks good. I would consider putting it between these two lines (115 and 117 in master):

  this.off('dispose');

  // Kill reference to this player

What's the context around the empty src call? It sounds like that might be a different issue, so we should probably take that one to a different thread.

[sethborg]

OK I updated component.js (pull request) btw it is this.off() not this.off('dispose') just curious where you got that from.

As for the videojs('bumpboxVideo').src(''); I was using that as my temporary fix to stop firefox from downloading the movie in the background but doing that causes IE8 to throw an error. Not sure if you care to put any logic in there to prevent playing a movie if the video url is empty or not.

[mmcc]

Just to have the reference, the associated PR: #1334