Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On release, update a tag/url on CDN always pointing to latest. #2109

Closed
dconnolly opened this issue May 1, 2015 · 2 comments
Closed

On release, update a tag/url on CDN always pointing to latest. #2109

dconnolly opened this issue May 1, 2015 · 2 comments

Comments

@dconnolly
Copy link
Contributor

So that we can always use latest on videojs.com, etc.
See videojs/videojs.com#24

@heff
Copy link
Member

heff commented May 1, 2015

So we used to have this with 3.0 and it was scary as hell every time we pushed a change, thinking we could break a ton of sites out there. See jQuery's issue too: http://blog.jquery.com/2014/07/03/dont-use-jquery-latest-js/

With 4.0 we switched to having minor versions auto-update with patches only, e.g. /4.5/video.js would get 4.5.1, 4.5.2, etc., but 4.4 would not get any of those updates.

We could increase this to major versions, so /5/video.js would always be the latest 5.x release. Even then I'd be tempted to add a built in console warning that says "don't use in production".

The other thing Matt talked about doing was publishing the package.json to the CDN, and checking that for the latest version.

I could go either way on those.

@gkatsev
Copy link
Member

gkatsev commented Nov 17, 2015

I think this was completed via the 5-unsafe cdn path.

@gkatsev gkatsev closed this as completed Nov 17, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants