Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Full Screen keeps video original size #3655

Closed
burnhamrobertp opened this issue Sep 29, 2016 · 9 comments
Closed

Video Full Screen keeps video original size #3655

burnhamrobertp opened this issue Sep 29, 2016 · 9 comments

Comments

@burnhamrobertp
Copy link

burnhamrobertp commented Sep 29, 2016

Most videos seem to be fine but others, such as this one:

http://distribution.bbb3d.renderfarming.net/video/mp4/bbb_sunflower_1080p_60fps_normal.mp4

Do not engage in full screen and simply stays in its original size with the rest of the screen having a black background. Video controls are properly positioned, but the actual video doesn't increase in size.

@gkatsev
Copy link
Member

gkatsev commented Sep 29, 2016

Seems to work fine for me. Can you put up a reduced test case showcasing the issue?

@bradjones1
Copy link

I am running into this using a Big Buck Bunny trailer test video, though I'm playing it with the contrib HLS extension. I will try to put up a test example soon.

screenshot from 2016-11-22 11-37-18

@misteroneill
Copy link
Member

Those audio tracks errors are odd/suspicious. What version of video.js is that?

Also, is this browser or OS-specific?

@bradjones1
Copy link

bradjones1 commented Dec 21, 2016

Those audio tracks errors are odd/suspicious. What version of video.js is that?

Version 5.8.8, off the CDN. I'm also using v. 3.16.13 of the HLS library, if that might make a difference.

Also, is this browser or OS-specific?

Same results on both Firefox and Chromium on Linux, haven't tried another OS.

@misteroneill
Copy link
Member

misteroneill commented Dec 22, 2016

@bradjones1 I put together a reduced test case and fullscreen seems fine in all browsers, but I'm on Mac OS X. It could be Linux-related.

The audioTracks error looks like a consequence of incompatible video.js and videojs-contrib-hls versions. videojs-contrib-hls v3.16.x expects video.js v5.10.1 or higher.

My example uses v5.10.8 and v3.16.14 and I don't see that error.

@bradjones1
Copy link

@misteroneill Thanks... I missed the dependency issue since it's not in the README, just the package.js. I will try this combination and follow up. Appreciate the test.

Is the 4.x branch of HLS still unstable at this point?

@bradjones1
Copy link

After testing with this a bit more, I think the culprit here was width/height CSS being applied to the video element itself, which when removed allowed the video to expand to fit the full screen.

For anyone else finding this via a Drupal integration, see this issue.

@svandecappelle
Copy link

This CSS could help you.
It caused by the width / height into DOM attributes are the most important attributes. Forcing them into CSS to important has solved mine.

.video-js .vjs-tech {
  width: 100% !important;
  height: 100% !important;
}

@gkatsev
Copy link
Member

gkatsev commented Jan 3, 2018

I think this has been fixed and answered, so, closing.

@gkatsev gkatsev closed this as completed Jan 3, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants