-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Full Screen keeps video original size #3655
Comments
Seems to work fine for me. Can you put up a reduced test case showcasing the issue? |
Those audio tracks errors are odd/suspicious. What version of video.js is that? Also, is this browser or OS-specific? |
Version 5.8.8, off the CDN. I'm also using v. 3.16.13 of the HLS library, if that might make a difference.
Same results on both Firefox and Chromium on Linux, haven't tried another OS. |
@bradjones1 I put together a reduced test case and fullscreen seems fine in all browsers, but I'm on Mac OS X. It could be Linux-related. The My example uses v5.10.8 and v3.16.14 and I don't see that error. |
@misteroneill Thanks... I missed the dependency issue since it's not in the README, just the Is the 4.x branch of HLS still unstable at this point? |
After testing with this a bit more, I think the culprit here was width/height CSS being applied to the video element itself, which when removed allowed the video to expand to fit the full screen. For anyone else finding this via a Drupal integration, see this issue. |
This CSS could help you.
|
I think this has been fixed and answered, so, closing. |
Most videos seem to be fine but others, such as this one:
http://distribution.bbb3d.renderfarming.net/video/mp4/bbb_sunflower_1080p_60fps_normal.mp4
Do not engage in full screen and simply stays in its original size with the rest of the screen having a black background. Video controls are properly positioned, but the actual video doesn't increase in size.
The text was updated successfully, but these errors were encountered: