Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lang): Fixed typos in german translation #6275

Merged
merged 1 commit into from
Nov 4, 2019
Merged

fix(lang): Fixed typos in german translation #6275

merged 1 commit into from
Nov 4, 2019

Conversation

philipp-birkl
Copy link
Contributor

Fixed some typos in the german translation.

@welcome
Copy link

welcome bot commented Oct 17, 2019

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

mister-ben
mister-ben reviewed Oct 18, 2019
View reviewed changes
lang/de.json Outdated
@@ -80,7 +80,7 @@
"Video Player": "Video-Player",
"Progress Bar": "Forschrittsbalken",
"progress bar timing: currentTime={1} duration={2}": "{1} von {2}",
"Volume Level": "Lautstärkestufe",
"Volume Level": "Lautstärkenstufe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure a Fugen-n belongs here (there are more results on Google without for example) but a simple "Lautstärke' is probably better here anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are completely right, it just seemed to be unnatural for me. I did check and in publications they seem to use one or the other interchangeably, however using the Version without Fugen-n more often. Sorry bout that.

I will change the pull request and edit it to Lautstärke.

philipp-birkl pushed a commit to philipp-birkl/video.js that referenced this pull request Oct 22, 2019
@danmichaelo @philipp-birkl
fix(lang): Fixed typos in german translation (videojs#6275)
5483fe1
mister-ben
mister-ben approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke!

@gkatsev gkatsev merged commit aeb9588 into videojs:master Nov 4, 2019
@welcome
Copy link

welcome bot commented Nov 4, 2019

Congrats on merging your first pull request! 🎉🎉🎉

This was referenced Mar 19, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mister-ben mister-ben mister-ben approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipp-birkl @gkatsev @mister-ben