Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: introduces core ES module. #6287

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Conversation

gjanblaszczyk
Copy link
Member

Description

The PR introduces an alternative ES module file for videojs core build.
I created this PR because I would like to use videojs core directly from the browser like this:

<script type="module"> import videojs from 'video.js/dist/alt/video.core.es.js'; </script>

For now, main videojs build supports umd, cjs and es module. Not sure why core build supports only cjs and umd.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev gkatsev added needs: LGTM Needs one or more additional approvals and removed needs: updates labels Nov 14, 2019
@gkatsev gkatsev merged commit 4f8c498 into videojs:master Nov 15, 2019
@gkatsev gkatsev removed the needs: LGTM Needs one or more additional approvals label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants