Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improves control bar hiding functionality #6400

Merged
merged 2 commits into from
Jan 15, 2020
Merged

fix: improves control bar hiding functionality #6400

merged 2 commits into from
Jan 15, 2020

Conversation

gjanblaszczyk
Copy link
Member

Description

A proposed fix for #6391

Specific Changes proposed

Adds support for mouseout event to catch the user click outside the player.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

gkatsev
gkatsev reviewed Jan 13, 2020
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems to fix the issue and it makes sense.

src/js/player.js Outdated Show resolved Hide resolved
@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Jan 14, 2020
@gkatsev gkatsev added tested and removed needs: LGTM Needs one or more additional approvals labels Jan 15, 2020
@gkatsev gkatsev merged commit 6f77778 into videojs:master Jan 15, 2020
This was referenced Mar 19, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjanblaszczyk @gkatsev @brandonocasey