-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume tooltip #6824
Add volume tooltip #6824
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hey, thanks for the PR. Totally forgot to take a look at it. Two main things that is that we should document and perhaps make it easier to hide the volume tooltip. Also, if the inline:false volume panel is added as the last thing in the control bar, we should potentially have the tooltip show up on the left so that it doesn't go outside the player boundary. @OwenEdwards thoughts on this? |
Having a tooltip is awesome, never realized that we were missing this! |
Thanks for the review and sorry for the late response. I am planning to update the PR this week. |
No worries @gjanblaszczyk, we appreciate the help. I was actually thinking of maybe merging this in and then having the direction get changed as a separate PR. However, if you think you can get this in soon, we may as well wait. |
Hi @gkatsev, I am pretty busy right now, so I think it is a good idea to merge this and then to have a separate PR for the improvements. I am planning to back to it as soon as I have some free time. |
+1 |
I opened up #7145 to not forget fixing the issue of the volume control being the last item in the control bar. |
Description
Add tooltip for volume level so the user knows what they will change too.
Maybe in the scope of WCAG "1.1.1 Non-text Content".
Specific Changes proposed
Add volume level tooltip.
Requirements Checklist