Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fullWindowOnEscKey handler #7224

Merged
merged 1 commit into from
May 11, 2021
Merged

fix: fullWindowOnEscKey handler #7224

merged 1 commit into from
May 11, 2021

Conversation

FredZeng
Copy link
Contributor

@FredZeng FredZeng commented May 8, 2021

Description

Calling player.enterFullWindow() directly will cause ESC keydown listener not working as expect.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@FredZeng
fix: fullWindowOnEscKey handler
a8001e4 
Calling `player.enterFullWindow()` directly will cause `ESC` keydown listener not working.
gkatsev
gkatsev approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense.

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label May 10, 2021
@gkatsev gkatsev merged commit e9953e5 into videojs:main May 11, 2021
@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label May 23, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
@FredZeng @edirub
fix: exit full window mode with Esc key (videojs#7224)
55c663b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@brandonocasey brandonocasey brandonocasey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FredZeng @gkatsev @brandonocasey @misteroneill