Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Type issues after migration from 7.21.x to 8.4.0 #8242

Open
anschm opened this issue Apr 17, 2023 · 8 comments
Open

Multiple Type issues after migration from 7.21.x to 8.4.0 #8242

anschm opened this issue Apr 17, 2023 · 8 comments
Labels
needs: triage This issue needs to be reviewed

Comments

@anschm
Copy link

anschm commented Apr 17, 2023

Description

After migration from videojs 7.21.x to 8.4.0 there are multiple type issues. The following types are missing and not exported:

  • videojs.PlayerOptions
  • videojs.Tech.SourceObject
  • videojs.Preload

In addition extending the Plugin type shows the TS error: TS2507: Type 'Function | typeof Plugin' is not a constructor function type.

Bildschirm­foto 2023-04-17 um 10 30 15

Reduced test case

https

Steps to reproduce

  1. Migrate to videojs 8.4.0

Errors

Missing types:

  • videojs.PlayerOptions
  • videojs.Tech.SourceObject
  • videojs.Preload
  • videojs.Plugin

What version of Video.js are you using?

8.4.0

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Chrome 103.0.5060.134

What OS(es) and version(s) does this occur with?

Mac

@anschm anschm added the needs: triage This issue needs to be reviewed label Apr 17, 2023
@kkatsi
Copy link

kkatsi commented May 15, 2023

I can confirm the missing types and want to add videojs.Player also.

@astelmack
Copy link

Running into this issue as well, and the changes in the types is not really covered in the breaking changes. Its a bit hard to use v8 if you have any custom components or plugins and are using Typescript at the moment.

Similarly there are issues with trying to use videojs.obj.mergeOptions given videojs.mergeOptions is now deprecated. That one doesn't necessarily seem to be typing related as this seems to be a runtime issue given I am getting a 'obj is not defined on videojs' error. A lot of the guides and documentation need a bit of a refresh after v8 has become the mainline version.

@anschm
Copy link
Author

anschm commented Aug 30, 2023

Any updates on this issues. Still present in 8.5.3. Its blocking to migrate from version 7 to 8.

@ekasprzyk
Copy link

Also just want to say that this issue is a bit more urgent since we bumped into a critical vulnerability of a package in the 7.x version's dependency xmldom, which we tried to resolve by upgrading into 8.x only to run right into the wall of 8.x's Typescript bindings.

@pmev0
Copy link

pmev0 commented Oct 19, 2023

still problem with react. cant install it with vite

@binhphan009
Copy link

same problem here :(

@uzbeki
Copy link

uzbeki commented Feb 5, 2024

any progress here? Cant use version 8 because of incomplete type bindings

@VMLuca
Copy link

VMLuca commented Oct 9, 2024

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

8 participants