-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Type issues after migration from 7.21.x to 8.4.0 #8242
Comments
I can confirm the missing types and want to add |
Running into this issue as well, and the changes in the types is not really covered in the breaking changes. Its a bit hard to use v8 if you have any custom components or plugins and are using Typescript at the moment. Similarly there are issues with trying to use |
Any updates on this issues. Still present in 8.5.3. Its blocking to migrate from version 7 to 8. |
Also just want to say that this issue is a bit more urgent since we bumped into a critical vulnerability of a package in the 7.x version's dependency xmldom, which we tried to resolve by upgrading into 8.x only to run right into the wall of 8.x's Typescript bindings. |
still problem with react. cant install it with vite |
same problem here :( |
any progress here? Cant use version 8 because of incomplete type bindings |
Any updates on this? |
Description
After migration from videojs 7.21.x to 8.4.0 there are multiple type issues. The following types are missing and not exported:
In addition extending the Plugin type shows the TS error: TS2507: Type 'Function | typeof Plugin' is not a constructor function type.
Reduced test case
https
Steps to reproduce
Errors
Missing types:
What version of Video.js are you using?
8.4.0
Video.js plugins used.
No response
What browser(s) including version(s) does this occur with?
Chrome 103.0.5060.134
What OS(es) and version(s) does this occur with?
Mac
The text was updated successfully, but these errors were encountered: