Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for #4583 (JAWS+IE doesn't announce BPB or play button) #5173

Conversation

OwenEdwards
Copy link
Member

Description

Workaround for #4583 (JAWS+IE doesn't announce BPB or play button)

Specific Changes proposed

Add ARIA role="application" to the <video> element if the browser is IE, as recommended by @stevefaulkner in FreedomScientific/standards-support#78 (comment).

Requirements Checklist

  • Feature implemented / Bug fixed
  • Change has been verified in an actual browser (IE11 & JAWS 2018)
  • Reviewed by Two Core Contributors

@OwenEdwards OwenEdwards requested a review from gkatsev May 15, 2018 05:11
@OwenEdwards OwenEdwards added a11y This item might affect the accessibility of the player screen reader JAWS, NVDA, VoiceOver, TalkBack, etc. needs: LGTM Needs one or more additional approvals labels May 15, 2018
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

Another workaround, which is probably not as good, is to add a dummy button element immediately after the video element for JAWS to swallow up.

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels May 23, 2018
@OwenEdwards
Copy link
Member Author

@gkatsev the problem with that is that focus will still move to that dummy button (if not, it doesn't fix the problem), and that dummy button will be unlabeled, which isn't good.

Hopefully Freedom Scientific/JAWS will fix this issue soon, but even then it will still work with this workaround since it's a workaround that they proposed themselves, so they'd be really shooting themselves in the foot if they fixed the problem in JAWS and afterward it didn't work with their own workaround!

@gkatsev
Copy link
Member

gkatsev commented May 23, 2018

yeah makes sense. This is definitely the better workaround.

@OwenEdwards OwenEdwards merged commit 2bc810d into videojs:master May 23, 2018
@OwenEdwards OwenEdwards deleted the workaround/jaws-and-ie11-dont-announce-bpb-or-play-button branch May 23, 2018 19:43
@stevefaulkner
Copy link

@OwenEdwards

but even then it will still work with this workaround since it's a workaround that they proposed themselves, so they'd be really shooting themselves in the foot if they fixed the problem in JAWS and afterward it didn't work with their own workaround!

There is no reason why the 'workaround' will have any negative effects if/when the JAWS+IE issues is resolved. Use of role=application is conforming for the video element in HTML.
Also note I am not a freedom scientific employee, so its not a workaround that freedom proposed.

@OwenEdwards OwenEdwards restored the workaround/jaws-and-ie11-dont-announce-bpb-or-play-button branch May 24, 2018 16:30
@OwenEdwards OwenEdwards deleted the workaround/jaws-and-ie11-dont-announce-bpb-or-play-button branch May 24, 2018 16:31
gkatsev pushed a commit that referenced this pull request May 24, 2018
…5206)

Freedom Scientific's recommended workaround for JAWS + IE not announcing the first button after a video element which doesn't have its own native controls (See FreedomScientific/standards-support#78).

This is the 6.x version of #5173 (2bc810d).

Fixes #4583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y This item might affect the accessibility of the player confirmed screen reader JAWS, NVDA, VoiceOver, TalkBack, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants