fix: Close keySession when player is disposed #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
approved these changes
Oct 5, 2022
gkatsev
approved these changes
Oct 6, 2022
src/eme.js
Outdated
| @@ -108,8 +108,9 @@ export const makeNewRequest = (requestOptions) => { | |||
|
|
|||
| eventBus.trigger('keysessioncreated'); | |||
|
|
|||
| return new Promise((resolve, reject) => { | |||
| player.on('dispose', keySession.close); | |||
There was a problem hiding this comment.
does this work properly to have the close() method not directly attached/bound to keySession?
would it be better to bind it or wrap in an arrow function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where a
keySessioncould continue to receive events and trigger license requests even after a player is disposed.Specific Additions
Call
keySession.close()on'dipose'.Relevant spec: https://www.w3.org/TR/encrypted-media/#x6.-mediakeysession-interface
close(): https://www.w3.org/TR/encrypted-media/#dom-mediakeysession-close