chore: update to generator v6 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
chore/generator-v6
branch
from
80d8595
to
c6a3a2f
Compare
brandonocasey
force-pushed
the
chore/generator-v6
branch
from
c6a3a2f
to
bd9d06a
Compare
gkatsev
reviewed
Jun 11, 2018
package.json
Outdated
| @@ -91,47 +77,50 @@ | |||
| "dependencies": { | |||
| "global": "^4.3.2", | |||
| "three": "0.92.0", | |||
| "video.js": "^6.2.7", | |||
| "video.js": "6.10.2 || ^7.0.3", | |||
There was a problem hiding this comment.
why 6.10.2 specifically? probably should stay ^6.2.7.
brandonocasey
force-pushed
the
chore/generator-v6
branch
from
e306cf7
to
4ddb308
Compare
brandonocasey
force-pushed
the
chore/generator-v6
branch
from
3a2d482
to
c6e931f
Compare
brandonocasey
force-pushed
the
chore/generator-v6
branch
from
a686f44
to
59faf17
Compare
gkatsev
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only real change here is switching from
sasstopostcss. All I did was use sass to generate unminifed css and used that as the source forsrc/plugin.cssdistSize Changes:Total gzip byte change
-849new
.min.js.gz: 185749.css.gz: 2355old
.min.js.gz: 186537.css.gz: 2416