New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reset event listeners on window correctly #119

Merged

brandonocasey merged 1 commit into master from fix/correct-event-listner-dispose

Aug 1, 2018

Contributor

brandonocasey commented Aug 1, 2018 •

edited

Loading

We add these listeners with true so we must remove them with true, or else nothing will happen.

Reported in #8

See the docs here:useCaption on https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener


          fix: dispose event listeners on window correctly

22947c1

misteroneill approved these changes

View reviewed changes

brandonocasey merged commit b6a8125 into master

brandonocasey mentioned this pull request

VR Plugin and associated event handlers are not disposed correctly #118

Closed

brandonocasey deleted the fix/correct-event-listner-dispose branch

August 1, 2018 21:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet