Fix/style override #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: weird camera aspect stretching when rotating devices fix: pseudo fullscreen on iOS fix: allow the player to start in cardboard mode
brandonocasey
force-pushed
the
fix/style-override
branch
from
edfd728
to
d87ee0b
Compare
brandonocasey
commented
Aug 11, 2017
| } | ||
|
|
||
| changeSize_() { | ||
| this.player_.width(window.innerWidth); |
There was a problem hiding this comment.
The window size changes during orientation when we are pseudo fullscreen on iOS
brandonocasey
commented
Aug 11, 2017
| }; | ||
| // we use this to stop webvr-polyfill from making the canvas take up more | ||
| // space then the video element | ||
| const setInherit = debounce((mut) => { |
There was a problem hiding this comment.
A hacky work-around for webvr-polyfills canvas style changes that we don't want.
misteroneill
approved these changes
Aug 11, 2017
mister-ben
pushed a commit
to mister-ben/videojs-vr
that referenced
this pull request
Dec 4, 2023
Three.js to v0.137.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: weird camera aspect ratio stretching
fix: pixelation issues on some devices
fix: allow the player to start in cardboard mode
fix: psudo fullscreen on iOS
Fixes #13
Based on #15