option to disable togglePlay #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adribarbeito
changed the title
brandonocasey
requested changes
Jun 14, 2021
There was a problem hiding this comment.
Hey @adribarbeito thanks for the pull request. Code looks good and functions as I would expect. Can you resolve the merge conflict, add the new option to the README, and add an example file for the new option?
|
Hi @brandonocasey , the changes requested were pushed. Thanks. |
brandonocasey
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature to disable the togglePlay manually.
This functionality is useful in live events so that users cannot stop the live, but still have a controlBar available.
Specific Changes proposed
The proposed changes includes a new option disableTogglePlay to flag on the initialization of the plugin and then use it in the canvas-player-controls.