Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FrontSide changed to BackSide due to three.js changes #88

Merged
merged 4 commits into from
May 23, 2018
Merged

fix: FrontSide changed to BackSide due to three.js changes #88

merged 4 commits into from
May 23, 2018

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented May 15, 2018 •
edited
Loading

Description

Fixes #81

Testing

NOTE: Make sure to remove the node_modules folder and re-install before testing/building this PR.

  • Verify that the latest browsers work with this plugin
    • iOS Safari
    • Android Chrome
    • Safari
    • Chrome
    • Firefox

@ishita12
Copy link

QA LGTM

@brandonocasey brandonocasey merged commit e58862d into master May 23, 2018
@brandonocasey brandonocasey deleted the fix/three-update branch May 23, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonocasey @ishita12 @misteroneill