fix: implement touch pan controls again #89
Conversation
| // expose private functions so that users can manually use controls | ||
| // and we can add orientation controls | ||
| if (m === 'OrbitControls') { | ||
| code = globalReplace(code, 'function rotateLeft\\(', 'rotateLeft = function('); |
There was a problem hiding this comment.
A somewhat hacky patch to OrbitControls to allow us to modify the movement a bit so that we can add on the movement from DeviceOrientationControls. I felt like this was a better alternative to Grabbing the code, storing it in our repo, and maintaining these small modifications.
brandonocasey
force-pushed
the
fix/touch-pan
branch
3 times, most recently
from
c2b7b4d
to
aeb5c96
Compare
brandonocasey
force-pushed
the
fix/touch-pan
branch
from
aeb5c96
to
46e00ff
Compare
|
QA LGTM |
brandonocasey
force-pushed
the
fix/touch-pan
branch
from
46e00ff
to
6b656d9
Compare
|
Hello, Sorry or my newbie question, I'm little bit confused how to make it works (movement with the mouse/touch). I incorporated the videojs-vr.min.js script to my page and the player worked perfectly with gyroscope. If I just add the plugin.js and the movements will work? What files should I complement? Again, apologies for the rookie question, feel free to delete if you are in the wrong place. Thank you for this great project. |
Description
Recently
webvr-polyfillremoved support for the touch panner controls that they used to add to their polyfill vr headset. This PR brings them back.Testing