Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support strict mode #15

Closed
gkatsev opened this issue Aug 8, 2017 · 2 comments · Fixed by videojs/video.js#6334
Closed

support strict mode #15

gkatsev opened this issue Aug 8, 2017 · 2 comments · Fixed by videojs/video.js#6334
Assignees
@gkatsev

Comments

@gkatsev
Copy link
Member

gkatsev commented Aug 8, 2017 •
edited
Loading

Right now, this breaks when used in strict mode because in createElement it tries to set localName back to the tagName but setting localName on the element isn't allowed in strict mode. Loose mode lets it slide, though.
Making a change to video.js to disable strict mode for now (videojs/video.js#4551) but it should be fixed here ultimately.
@gkatsev
Copy link
Member Author

gkatsev commented Aug 8, 2017

And videojs/video.js#4551 should be reverted when this is fixed.

@gkatsev gkatsev mentioned this issue Aug 8, 2017
Merged
@gjanblaszczyk gjanblaszczyk mentioned this issue Aug 18, 2019
Merged
@gkatsev
Copy link
Member Author

gkatsev commented Nov 26, 2019

#40 fixes this. We should revisit and revert the video.js change when updating to vtt.js 0.15.0.

@gkatsev gkatsev self-assigned this Nov 26, 2019
@gkatsev gkatsev mentioned this issue Nov 26, 2019
Merged
gkatsev added a commit to videojs/video.js that referenced this issue Dec 2, 2019
@gkatsev
fix: turn on strict mode again (#6334)
ca84448 
We had to turn off strict mode (#4551) in Video.js due to a change in vtt.js. That has now been fixed in videojs/vtt.js#40 and released as part of 0.15.2 which will be available via #6333.

Fixes videojs/vtt.js#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkatsev gkatsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: turn on strict mode again videojs/video.js
1 participant
@gkatsev