fix: turn on strict mode again #6334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
commented
Nov 26, 2019
| @@ -1218,7 +1218,7 @@ Html5.Events = [ | |||
| ['featuresNativeVideoTracks', 'supportsNativeVideoTracks'], | |||
| ['featuresNativeAudioTracks', 'supportsNativeAudioTracks'] | |||
| ].forEach(function([key, fn]) { | |||
| defineLazyProperty(Html5.prototype, key, () => Html5[fn](), false); | |||
| defineLazyProperty(Html5.prototype, key, () => Html5[fn](), true); | |||
There was a problem hiding this comment.
The last property here was used to see whether we should create a setter for the property or not. Given that these values do change, particularly with text tracks, we do want these to be settable but because we weren't using strict mode, it was being set without a problem. Instead, we should just make sure these are settable.
misteroneill
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to turn off strict mode (#4551) in Video.js due to a change in vtt.js. That has now been fixed in videojs/vtt.js#40 and released as part of 0.15.2 which will be available via #6333.
Fixes videojs/vtt.js#15