Extract CellSet to ViennaCS Library #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation for #77.
I removed all the cellSet files except csSurfaceCellSet.hpp (which wasn't moved to ViennaCS yet) and adjusted the includes.
(I accidentally modified psSmartPointer in csSurfaceCellSet.hpp, should I undo those changes?)
What still needs to be changed is all the CMake stuff and Python bindings, and the Readme (and testing if it works).
If the LS and Ray dependencies are replaced with only ViennaCS, it might be a problem, because in tests/CMakeLists.txt and examples/CMakeLists.txt, the
VIENNAPS_SYSTEM_VIENNALS
andVIENNAPS_SYSTEM_VIENNARAY
variables are still used. Should it still do thefind_package(ViennaLS)
and other calls, even if it's no longer a direct dependency? Or can all 3 libraries be listed as a dependency?I don't want to mess up the build system, so I'd prefer if you do this part or tell me how to proceed.