Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Object Property Formatting in Prerender.js #1717

Closed
zakisudev opened this issue Jun 27, 2024 · 1 comment
Closed

Inconsistent Object Property Formatting in Prerender.js #1717

zakisudev opened this issue Jun 27, 2024 · 1 comment
Labels

Comments

@zakisudev
Copy link

Description

While reviewing the Prerender.js, I noticed an inconsistency in the formatting of object properties within the array returned by the pageContext function. Specifically, the spacing around the property names and values is inconsistent. This is a minor stylistic issue but improving consistency can enhance code readability and maintainability.

Current Implementation:
return [
{ url: '/' },
{ url: '/about' },
{url: '/projects'},
{url: '/contact'},
]

Suggested Fix:
It would be beneficial to standardize the formatting by adding spaces inside the curly braces for all objects in the array. This would align with common JavaScript styling practices.

Proposed Change:
return [
{ url: '/' },
{ url: '/about' },
{ url: '/projects' },
{ url: '/contact' },
]

This change would not affect the functionality of the code but would make the codebase more uniform and easier to read.

@brillout
Copy link
Member

I don't understand, and it doesn't seem to be a bug thus closing.

@brillout brillout closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants