Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pageContext._pageId part of the official API #553

Closed
brillout opened this issue Dec 12, 2022 · 1 comment
Closed

Make pageContext._pageId part of the official API #553

brillout opened this issue Dec 12, 2022 · 1 comment
Labels
enhancement ✨ New feature or request

Comments

@brillout
Copy link
Member

Description

Many users use the internal property pageContext._pageId for various reasons.

It should be renamed pageContext.pageId while considering changing how the page ID is determined to be a breaking change.

We should make the page ID more stable. A fairly stable page ID would be to take the Filesystem Route as ID.

I'm postponing this until the new VPS design is released. In the meantime you can safely use pageContext._pageId as I won't break it. (The new page ID will live at pageContext.pageId while the current ID will still live at pageContext._pageId.)

If there is interest, VPS could allow users to name pages, ensuring that the page name doesn't change no matter where the page file lives. (With the proposed design, when the user moves files around, then the page ID changes.)

@brillout
Copy link
Member Author

Postponing after #341.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant