Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added neovim support. #19

Merged
merged 3 commits into from
Feb 12, 2016
Merged

Added neovim support. #19

merged 3 commits into from
Feb 12, 2016

Conversation

RianFuro
Copy link
Contributor

Added an algorithm to consider neovims different command set. Added test cases to reflect neovim features and the absence of neovim features for regular vim parsing. Added a toggle option as an argument that defaults to regular vim if not specified.

The changes are designed in a way so the default behavior is not changed. Using the toggle should be completely optional.

After I was done i realized that the javascript part looks like it's created automatically, but oh well :D

…eovim features and the absence of neovim features for regular vim parsing. Added a toggle option as an argument that defaults to regular vim if not specified for all languages.
@RianFuro RianFuro mentioned this pull request Feb 11, 2016
@ynkdir
Copy link
Member

ynkdir commented Feb 12, 2016

Thank you.

js/vimlparser.js and py/vimlparser.py should not be edited by hand because it is generated file. You can generate them with :so js/jscompiler.vim and :so py/pycompiler.vim. Could you fix it?

… couldn't handle a:0 etc. then generated the .js and .py files.
@RianFuro
Copy link
Contributor Author

Aaah, that's how it works :) The parser doesn't do the optional --neovim cli parameter though; anyway to fix that? I couldn't find where the entry point is generated :/

@ynkdir
Copy link
Member

ynkdir commented Feb 12, 2016

I couldn't find where the entry point is generated

That is in js/vimlfunc.js and py/vimlfunc.py.

@RianFuro
Copy link
Contributor Author

Thanks! :) Anything else?

@ynkdir
Copy link
Member

ynkdir commented Feb 12, 2016

It's complete. Thanks!

ynkdir added a commit that referenced this pull request Feb 12, 2016
@ynkdir ynkdir merged commit 2fff43c into vim-jp:master Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants