Skip to content

Commit

Permalink
patch 8.0.1267: Test_swap_group may leave file behind
Browse files Browse the repository at this point in the history
Problem:    Test_swap_group may leave file behind.
Solution:   Add a try/finally.
  • Loading branch information
brammool committed Nov 4, 2017
1 parent ffe010f commit 5842a74
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 20 deletions.
42 changes: 22 additions & 20 deletions src/testdir/test_swap.vim
Original file line number Diff line number Diff line change
Expand Up @@ -56,27 +56,29 @@ func Test_swap_group()
throw 'Skipped: need at least two groups, got ' . string(groups)
endif

call delete('Xtest')
split Xtest
call setline(1, 'just some text')
wq
if system('ls -l Xtest') !~ ' ' . groups[0] . ' \d'
throw 'Skipped: test file does not have the first group'
else
silent !chmod 640 Xtest
call system('chgrp ' . groups[1] . ' Xtest')
if system('ls -l Xtest') !~ ' ' . groups[1] . ' \d'
throw 'Skipped: cannot set second group on test file'
try
call delete('Xtest')
split Xtest
call setline(1, 'just some text')
wq
if system('ls -l Xtest') !~ ' ' . groups[0] . ' \d'
throw 'Skipped: test file does not have the first group'
else
split Xtest
let swapname = substitute(execute('swapname'), '[[:space:]]', '', 'g')
call assert_match('Xtest', swapname)
" Group of swapfile must now match original file.
call assert_match(' ' . groups[1] . ' \d', system('ls -l ' . swapname))
silent !chmod 640 Xtest
call system('chgrp ' . groups[1] . ' Xtest')
if system('ls -l Xtest') !~ ' ' . groups[1] . ' \d'
throw 'Skipped: cannot set second group on test file'
else
split Xtest
let swapname = substitute(execute('swapname'), '[[:space:]]', '', 'g')
call assert_match('Xtest', swapname)
" Group of swapfile must now match original file.
call assert_match(' ' . groups[1] . ' \d', system('ls -l ' . swapname))

bwipe!
bwipe!
endif
endif
endif

call delete('Xtest')
finally
call delete('Xtest')
endtry
endfunc
1 change: 1 addition & 0 deletions src/testdir/test_undo.vim
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ func Test_undojoin_redo()
endfunc

func Test_undo_write()
call delete('Xtest')
split Xtest
call feedkeys("ione one one\<Esc>", 'xt')
w!
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
1267,
/**/
1266,
/**/
Expand Down

0 comments on commit 5842a74

Please sign in to comment.