Skip to content

Commit

Permalink
updated for version 7.3.1247
Browse files Browse the repository at this point in the history
Problem:    New regexp engine: '[ ]\@!\p\%([ ]\@!\p\)*:' does not always match.
Solution:   When there is a PIM add a duplicate state that starts at another
            position.
  • Loading branch information
brammool committed Jun 26, 2013
1 parent b893ac2 commit a016912
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 8 deletions.
17 changes: 9 additions & 8 deletions src/regexp_nfa.c
Original file line number Diff line number Diff line change
Expand Up @@ -3642,14 +3642,14 @@ sub_equal(sub1, sub2)
if (i < sub1->in_use)
s1 = sub1->list.multi[i].start.lnum;
else
s1 = 0;
s1 = -1;
if (i < sub2->in_use)
s2 = sub2->list.multi[i].start.lnum;
else
s2 = 0;
s2 = -1;
if (s1 != s2)
return FALSE;
if (s1 != 0 && sub1->list.multi[i].start.col
if (s1 != -1 && sub1->list.multi[i].start.col
!= sub2->list.multi[i].start.col)
return FALSE;
}
Expand Down Expand Up @@ -3931,8 +3931,9 @@ addstate(l, state, subs, pim, off)
if (state->lastlist[nfa_ll_index] == l->id)
{
/* This state is already in the list, don't add it again,
* unless it is an MOPEN that is used for a backreference. */
if (!nfa_has_backref)
* unless it is an MOPEN that is used for a backreference or
* when there is a PIM. */
if (!nfa_has_backref && pim == NULL)
{
skip_add:
#ifdef ENABLE_LOG
Expand All @@ -3949,9 +3950,9 @@ addstate(l, state, subs, pim, off)
goto skip_add;
}

/* When there are backreferences the number of states may be (a
* lot) bigger than anticipated. */
if (nfa_has_backref && l->n == l->len)
/* When there are backreferences or PIMs the number of states may
* be (a lot) bigger than anticipated. */
if (l->n == l->len)
{
int newlen = l->len * 3 / 2 + 50;

Expand Down
1 change: 1 addition & 0 deletions src/testdir/test64.in
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ STARTTEST
:call add(tl, [2, '^\%(.*bar\)\@!.*\zsfoo', ' bar foo '])
:call add(tl, [2, '^\%(.*bar\)\@!.*\zsfoo', ' foo bar '])
:call add(tl, [2, '^\%(.*bar\)\@!.*\zsfoo', ' foo xxx ', 'foo'])
:call add(tl, [2, '[ ]\@!\p\%([ ]\@!\p\)*:', 'implicit mappings:', 'mappings:'])
:"
:"""" Combining different tests and features
:call add(tl, [2, '[[:alpha:]]\{-2,6}', '787abcdiuhsasiuhb4', 'ab'])
Expand Down
3 changes: 3 additions & 0 deletions src/testdir/test64.ok
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,9 @@ OK 2 - ^\%(.*bar\)\@!.*\zsfoo
OK 0 - ^\%(.*bar\)\@!.*\zsfoo
OK 1 - ^\%(.*bar\)\@!.*\zsfoo
OK 2 - ^\%(.*bar\)\@!.*\zsfoo
OK 0 - [ ]\@!\p\%([ ]\@!\p\)*:
OK 1 - [ ]\@!\p\%([ ]\@!\p\)*:
OK 2 - [ ]\@!\p\%([ ]\@!\p\)*:
OK 0 - [[:alpha:]]\{-2,6}
OK 1 - [[:alpha:]]\{-2,6}
OK 2 - [[:alpha:]]\{-2,6}
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
1247,
/**/
1246,
/**/
Expand Down

0 comments on commit a016912

Please sign in to comment.