Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In a terminal Visual fg is invisible if set termguicolors set for default colorscheme #14024

Closed
habamax opened this issue Feb 13, 2024 · 2 comments
Labels

Comments

@habamax
Copy link
Contributor

habamax commented Feb 13, 2024

Steps to reproduce

  1. vim -Nu NONE
  2. :set termguicolors
  3. add some text and select it

image

https://www.reddit.com/r/vim/comments/1apo5xb/is_that_normal_selection_in_vim/

Expected behaviour

Text in Visual should be visible.

Version of Vim

9.1.104

Environment

debian, xterm/st

Logs and stack traces

No response

@habamax habamax added the bug label Feb 13, 2024
@habamax
Copy link
Contributor Author

habamax commented Feb 13, 2024

I still think GUI Visual of default should stay the same, but for termguicolors + terminal we would need to set fg to black, @chrisbra what do you think?

@habamax
Copy link
Contributor Author

habamax commented Feb 13, 2024

Or to simplify everything, just set it to black no matter GUI or not.

zeertzjq added a commit to zeertzjq/neovim that referenced this issue Feb 15, 2024
Problem:  Visual highlight hard to read with 'termguicolors'
          (Maxim Kim)
Solution: Set Visual GUI foreground to black (with background=light)
          and lightgrey (with background=dark)
          (Maxim Kim)

fixes: vim/vim#14024
closes: vim/vim#14025

vim/vim@34e4a05

Co-authored-by: Maxim Kim <habamax@gmail.com>
zeertzjq added a commit to zeertzjq/neovim that referenced this issue Feb 15, 2024
Problem:  Visual highlight hard to read with 'termguicolors'
          (Maxim Kim)
Solution: Set Visual GUI foreground to black (with background=light)
          and lightgrey (with background=dark)
          (Maxim Kim)

fixes: vim/vim#14024
closes: vim/vim#14025

vim/vim@34e4a05

Co-authored-by: Maxim Kim <habamax@gmail.com>
glepnir pushed a commit to glepnir/neovim that referenced this issue Mar 31, 2024
Problem:  Visual highlight hard to read with 'termguicolors'
          (Maxim Kim)
Solution: Set Visual GUI foreground to black (with background=light)
          and lightgrey (with background=dark)
          (Maxim Kim)

fixes: vim/vim#14024
closes: vim/vim#14025

vim/vim@34e4a05

Co-authored-by: Maxim Kim <habamax@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant