problem: Visual is unreadable if termguicolors is set #14025
Conversation
solution: Set Visual guifg to black(light) and lightgrey(dark)
|
gui
gui and
|
|
gui,
|
|
I don't know how to distinguish terminal + termguicolors vs pure gui so here |
|
so what exactly is the problem here? I tried in an ordinary xterm |
|
Try with another terminal that will fail detecting dark background (urxvt, windows terminal, simple terminal, konsole, gnome-terminal, etc). You either in putty or xterm (putty is forcefully set to use dark background, xterm properly reports bg color with OSC and vim can detect that bg is dark). |
|
Those are set to dark:
The rest would depend on https://github.com/vim/vim/blob/master/src/term.c#L3212-L3244 |
|
putty is my goto terminal, I don't see it there. I tried
I still cannot reproduce. But I think the patch is good. Let's add some specific gui foreground color for Visual then. |
Problem: Visual highlight hard to read with 'termguicolors'
(Maxim Kim)
Solution: Set Visual GUI foreground to black (with background=light)
and lightgrey (with background=dark)
(Maxim Kim)
fixes: vim/vim#14024
closes: vim/vim#14025
vim/vim@34e4a05
Co-authored-by: Maxim Kim <habamax@gmail.com>
Problem: Visual highlight hard to read with 'termguicolors'
(Maxim Kim)
Solution: Set Visual GUI foreground to black (with background=light)
and lightgrey (with background=dark)
(Maxim Kim)
fixes: vim/vim#14024
closes: vim/vim#14025
vim/vim@34e4a05
Co-authored-by: Maxim Kim <habamax@gmail.com>
vim/vim#14025 changed the default from `guifg=NONE` to `guifg=LightGrey`, so we must now explicitly `guifg=NONE` in order to unset it, so that syntax highlighting is preserved in visual mode.
vim/vim#14025 changed the default from `guifg=NONE` to `guifg=LightGrey`, so we must now explicitly `guifg=NONE` in order to unset it, so that syntax highlighting is preserved in visual mode.
Problem: Visual highlight hard to read with 'termguicolors'
(Maxim Kim)
Solution: Set Visual GUI foreground to black (with background=light)
and lightgrey (with background=dark)
(Maxim Kim)
fixes: vim/vim#14024
closes: vim/vim#14025
vim/vim@34e4a05
Co-authored-by: Maxim Kim <habamax@gmail.com>
solution: Set Visual guifg to black(light) and lightgrey(dark)
Relates #14024