vim-patch:9.1.0106: Visual highlight hard to read with 'termguicolors'

Problem: Visual highlight hard to read with 'termguicolors' (Maxim Kim) Solution: Set Visual GUI foreground to black (with background=light) and lightgrey (with background=dark) (Maxim Kim) fixes: vim/vim#14024 closes: vim/vim#14025 vim/vim@34e4a05 Co-authored-by: Maxim Kim <habamax@gmail.com>
zeertzjq · Feb 14, 2024 · 4916498 · 4916498
1 parent 440ce0d
commit 4916498
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/runtime/colors/vim.lua b/runtime/colors/vim.lua
@@ -231,7 +231,7 @@ if vim.o.background == 'light' then
   hi('SpellRare',    { sp = 'Magenta', undercurl = true,           ctermbg = 'LightMagenta' })
   hi('TabLine',      { bg = 'LightGrey', underline = true,         ctermfg = 'Black', ctermbg = 'LightGrey', cterm = { underline = true } })
   hi('Title',        { fg = 'Magenta', bold = true,                ctermfg = 'DarkMagenta' })
-  hi('Visual',       { bg = 'LightGrey',                           ctermfg = 'Black', ctermbg = 'Grey' })
+  hi('Visual',       { fg = 'Black', bg = 'LightGrey',             ctermfg = 'Black', ctermbg = 'Grey' })
   hi('WarningMsg',   { fg = 'Red',                                 ctermfg = 'DarkRed' })
   hi('Comment',      { fg = 'Blue',                                ctermfg = 'DarkBlue' })
   hi('Constant',     { fg = 'Magenta',                             ctermfg = 'DarkRed' })
@@ -270,7 +270,7 @@ else
   hi('SpellRare',    { sp = 'Magenta', undercurl = true,          ctermbg = 'Magenta' })
   hi('TabLine',      { bg = 'DarkGrey', underline = true,         ctermfg = 'White', ctermbg = 'DarkGrey', cterm = { underline = true } })
   hi('Title',        { fg = 'Magenta', bold = true,               ctermfg = 'LightMagenta' })
-  hi('Visual',       { bg = '#575757',                            ctermfg = 'Black', ctermbg = 'Grey' })
+  hi('Visual',       { fg = 'LightGrey', bg = '#575757',          ctermfg = 'Black', ctermbg = 'Grey' })
   hi('WarningMsg',   { fg = 'Red',                                ctermfg = 'LightRed' })
   hi('Comment',      { fg = '#80a0ff',                            ctermfg = 'Cyan' })
   hi('Constant',     { fg = '#ffa0a0',                            ctermfg = 'Magenta' })