Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

danish localisation #14703

Closed
wants to merge 1 commit into from
Closed

danish localisation #14703

wants to merge 1 commit into from

Conversation

ronin49
Copy link
Contributor

@ronin49 ronin49 commented May 2, 2024

No description provided.

@chrisbra
Copy link
Member

chrisbra commented May 2, 2024

ping @scootergrisen

@scootergrisen
Copy link

The changes make no sense.

@ronin49
Copy link
Contributor Author

ronin49 commented May 3, 2024

@chrisbra
close this,
#10703,
#10161

@chrisbra
Copy link
Member

chrisbra commented May 3, 2024

I am going to close this and the other PR from @ronin49.

You seem to be running this through some automatic machine translation, which I am afraid does not help to make translations better. I got a few complaints already about the bad quality.

I would rather prefer that the translations submitted make sense for someone speaking this language, so I don't think this helps much. It also takes away time and effort to review your PRs which we could spend on other things.

Also please don't just try to submit double PRs like #14710 .

Thanks for understanding

@k-takata
Copy link
Member

k-takata commented May 7, 2024

@chrisbra You have already merged some of the PRs from @ronin49.
Are you going to revert them or keep them?

You seem to be running this through some automatic machine translation, which I am afraid does not help to make translations better.

Agree. Recent machine translation is far better than before. But it is still not enough for the translation of the user interface.
Especially, the problem is that menus and messages don't have enough context. We often need to run the program and/or check the source code to understand the context.

@chrisbra
Copy link
Member

chrisbra commented May 7, 2024

yeah I know, it perhaps was a mistake to merge. But I thought it was maybe better having a bit of updated translations rather than no translations. (even so they might not be completely correct). Although it's a bit contradictual to keep those in and have other closed un-merged.

Should we revert the rest as well?

@k-takata
Copy link
Member

k-takata commented May 7, 2024

Okay, let's keep them and wait feedback from native speakers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants