Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #5

Closed
mehulmpt opened this issue Apr 10, 2020 · 6 comments
Closed

TypeScript support #5

mehulmpt opened this issue Apr 10, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@mehulmpt
Copy link

Currently, the player does not include types and hence the typescript support is missing. Maybe this could be added somewhere on the roadmap later on to support typescript?

Thanks for the player!

@mihar-22
Copy link
Contributor

Hey @mehulmpt that's definitely on the roadmap! Hopefully very soon.

@mihar-22 mihar-22 added the enhancement New feature or request label Apr 14, 2020
@bmamouri
Copy link

Any update on TypeScript support?

@mihar-22
Copy link
Contributor

Hey @bmamouri unfortunately not yet because I've been really busy with some other work. I'm planning on adding TS support and framework integrations next week.

@bmamouri
Copy link

Thank you @mihar-22, and well done on the great library.

@mihar-22
Copy link
Contributor

Apologies on this issue because my other work has put me way off schedule for this library. I'm actually planning a version 2 rewrite which I'll make an announcement for hopefully soon 😅 I'm intending on rewriting the entire library in Typescript so that should automatically solve this issue. I'll reference this issue when I create the new announcement.

@mihar-22
Copy link
Contributor

Closing this in favour of v2, feel free to provide any feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants